Re: houston, we have a problem- 2.10 showstoppers

[Vincent Untz <vincent vuntz net>]

Le lundi 28 f�ier 2005 �8:40 -0600, Federico Mena Quintero a �it :
>On Mon, 2005-02-28 at 23:23 +0100, Vincent Untz wrote:
>
>> Matthias has a nice explanation of what is possibly happening:
>>   http://bugzilla.gnome.org/show_bug.cgi?id=146075#c89
>> 
>> I'm not sure it explains why the patch [1] works around the problem,
>> though.
>> 
>> [1] http://bugzilla.gnome.org/attachment.cgi?id=34858&action=view
>
>It doesn't really fix the problem, although gdk_drawable_copy_to_image()
>does a server grab.  It will still not be reliable because you are
>getting the pixmap ID and then the image data in a non-atomic fashion:
>the code doesn't even check for the returned image being null.
>
>You need to
>
>0. [receive notification from the server that the _XROOTPMAP_ID property
>changed]
>1. grab the server
>2. get the value of _XROOTPMAP_ID
>3. transfer the pixmap to a pixbuf
>4. ungrab the server

Thanks Federico. I made a patch that seems to work (at least for me).
http://bugzilla.gnome.org/attachment.cgi?id=38081&action=view

Could you open a bug about the ugly hacks we're doing so that it doesn't
get forgotten for 2.12?

Thanks again,

Vincent

-- 
Les gens heureux ne sont pas press�