Re: egg-recent isn't threadsafe

[Murray Cumming <murrayc murrayc com>]

OK, I trust your judgemnet. 1 of 2 approvals. Will you coordinate with
the application maintainers?

On Sat, 2004-09-04 at 01:02 -0400, Matthias Clasen wrote:
> Looking at somewhat mysterious occasional panel crashes when saving
> files in gedit, jrb and I discovered today that egg-recent isn't
> threadsafe, since it installs a timeout which isn't protected by
> GDK_THREADS_ENTER/_LEAVE. 
> While the fix is fairly trivial, the fact that it applies to a module
> that has been copied all through Gnome makes fixing this a giant code
> freeze break. We need release team approval to commit the attached patch
> to libegg, and then all apps using egg-recent need to update their
> copies. The alternative is unpredictable crashes from all multithreaded
> apps using egg-recent (this includes all apps using gnome-vfs + egg-
> recent). Not nice. 
> This shows again that code sharing is nice for prototyping, but a
> disaster for wide adoption; egg-recent really has to find a permanent
> home for Gnome 2.10.
> 
> Regards, 
> 
> Matthias
> _______________________________________________
> release-team mailing list
> release-team gnome org
> http://mail.gnome.org/mailman/listinfo/release-team
-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com