Re: Porposing libgnomesu for 2.10

[Kjartan Maraas <kmaraas broadpark no>]

fre, 29,.10.2004 kl. 15.30 +0200, skrev Hongli Lai:
> Luca Ferretti wrote:
> > Review dialog to make HIG-compliant:
> >       * Use the GTK-DIALOG-AUTHENTICATION stock icon in dialogs, as
> >         suggested in HIG -> Alerts
> >       * Maybe change the Run button to OK
> 
> The action performed *is* running a program. Why would Run not be 
> appropriate?
> 
> 
> >       * remove the "verifying password" and use mouse_wait
> 
> I think the "verifying password" label is more obvious than just a busy 
> mouse cursor, and doesn't give as much of an impression of freezing the 
> application.
> 
> 
> > == Bug fixing ==
> > 
> > Compilation fails on su-backend/su.c, Mandrake 10.1 Community, here the
> > log
> 
> This should have been fixed in CVS.

Here's a few more cleanups and build fixes.

Cheers and have a nice weekend all
Kjartan

? Makefile
? Makefile.in
? aclocal.m4
? autom4te.cache
? config.log
? config.status
? configure
? intltool-extract
? intltool-merge
? intltool-update
? libgnomesu-1.0.pc
? libtool
? mkinstalldirs
? warnings
? autopackage/Makefile
? autopackage/Makefile.in
? doc/Makefile
? doc/Makefile.in
? nautilus/GNOME_SuperUser_Component.server
? nautilus/GNOME_SuperUser_Component.server.in
? nautilus/Makefile
? nautilus/Makefile.in
? pam-backend/Makefile
? pam-backend/Makefile.in
? pam-backend/gnomesu-pam-backend
? src/Makefile
? src/Makefile.in
? src/ui/Makefile
? src/ui/Makefile.in
? su-backend/Makefile
? su-backend/Makefile.in
? su-backend/gnomesu-backend
? tools/Makefile
? tools/Makefile.in
? tools/gnomesu
Index: nautilus/gnome-su-component.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/nautilus/gnome-su-component.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 gnome-su-component.c
--- nautilus/gnome-su-component.c	20 Sep 2003 11:19:24 -0000	1.1.1.1
+++ nautilus/gnome-su-component.c	29 Oct 2004 14:19:18 -0000
@@ -58,7 +58,7 @@ impl_Bonobo_Listener_event (PortableServ
 	argv[1] = "--no-desktop";
 	for (i = 0; i < list->_length; i++)
 		argv[i + 2] = list->_buffer[i];
-	gnome_su_spawn_async (NULL, argv, NULL);
+	gnomesu_spawn_async (NULL, argv, NULL);
 	g_free (argv);
 }
 
Index: src/consolehelper.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/src/consolehelper.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 consolehelper.c
--- src/consolehelper.c	20 Sep 2003 11:19:22 -0000	1.1.1.1
+++ src/consolehelper.c	29 Oct 2004 14:19:18 -0000
@@ -106,7 +106,7 @@ spawn_async (gchar *user, gchar **argv, 
 
 
 GnomeSuService *
-__gnomesu_consolehelper_service_new ()
+__gnomesu_consolehelper_service_new (void)
 {
 	GnomeSuService *service;
 
Index: src/pam.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/src/pam.c,v
retrieving revision 1.4
diff -u -p -r1.4 pam.c
--- src/pam.c	14 Jul 2004 12:17:21 -0000	1.4
+++ src/pam.c	29 Oct 2004 14:19:18 -0000
@@ -397,7 +397,7 @@ spawn_async (gchar *user, gchar **argv, 
 
 
 GnomeSuService *
-__gnomesu_pam_service_new ()
+__gnomesu_pam_service_new (void)
 {
 	GnomeSuService *service;
 
Index: src/prefix.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/src/prefix.c,v
retrieving revision 1.1
diff -u -p -r1.1 prefix.c
--- src/prefix.c	14 Jul 2004 12:17:21 -0000	1.1
+++ src/prefix.c	29 Oct 2004 14:19:18 -0000
@@ -226,7 +226,7 @@ static pthread_once_t br_thread_key_once
 
 
 static void
-br_thread_local_store_fini ()
+br_thread_local_store_fini (void)
 {
 	char *specific;
 
@@ -250,7 +250,7 @@ br_str_free (void *str)
 
 
 static void
-br_thread_local_store_init ()
+br_thread_local_store_init (void)
 {
 	if (pthread_key_create (&br_thread_key, br_str_free) == 0)
 		atexit (br_thread_local_store_fini);
Index: src/su.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/src/su.c,v
retrieving revision 1.3
diff -u -p -r1.3 su.c
--- src/su.c	14 Jul 2004 12:17:21 -0000	1.3
+++ src/su.c	29 Oct 2004 14:19:18 -0000
@@ -386,7 +386,7 @@ spawn_async (gchar *user, gchar **argv, 
 
 
 GnomeSuService *
-__gnomesu_su_service_new ()
+__gnomesu_su_service_new (void)
 {
 	GnomeSuService *service;
 
Index: src/sudo.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/src/sudo.c,v
retrieving revision 1.4
diff -u -p -r1.4 sudo.c
--- src/sudo.c	7 Nov 2003 14:28:26 -0000	1.4
+++ src/sudo.c	29 Oct 2004 14:19:18 -0000
@@ -341,7 +341,7 @@ spawn_async (gchar *user, gchar **argv, 
 
 
 GnomeSuService *
-__gnomesu_sudo_service_new ()
+__gnomesu_sudo_service_new (void)
 {
 	GnomeSuService *service;
 
Index: src/utils.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/src/utils.c,v
retrieving revision 1.7
diff -u -p -r1.7 utils.c
--- src/utils.c	27 Oct 2004 11:41:33 -0000	1.7
+++ src/utils.c	29 Oct 2004 14:19:18 -0000
@@ -203,7 +203,7 @@ __libgnomesu_load_glade (gchar *basename
 
 /* Initialize gettext stuff */
 void
-__libgnomesu_init ()
+__libgnomesu_init (void)
 {
 	static int initialized = 0;
 
Index: su-backend/common.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/su-backend/common.c,v
retrieving revision 1.2
diff -u -p -r1.2 common.c
--- su-backend/common.c	9 Apr 2004 19:00:02 -0000	1.2
+++ su-backend/common.c	29 Oct 2004 14:19:18 -0000
@@ -66,7 +66,7 @@ xputenv (const char *val)
 static gchar *xauth_data = NULL;
 
 static void
-saveXauth ()
+saveXauth (void)
 {
 	FILE *p;
 	GString *data;
Index: su-backend/su.c
===================================================================
RCS file: /cvs/gnome/libgnomesu/su-backend/su.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 su.c
--- su-backend/su.c	20 Sep 2003 11:19:23 -0000	1.1.1.1
+++ su-backend/su.c	29 Oct 2004 14:19:18 -0000
@@ -109,13 +109,13 @@ uid_t getuid ();
 /* The user to become if none is specified.  */
 #define DEFAULT_USER "root"
 
-char *crypt ();
+char *crypt(const char *key, const char *salt);
 char *getusershell ();
 void endusershell ();
 void setusershell ();
 
 char *base_name ();
-char *xstrdup ();
+char *xstrdup (char *pw_name);
 
 extern char **environ;
 
@@ -223,7 +223,7 @@ int
 main (int argc, char **argv)
 {
   const char *new_user;
-  char **command = 0;
+  char **command = NULL;
   struct passwd *pw;
   struct passwd pw_copy;
   int infd, outfd, i;