Re: Issues with gnome cvs (regressions)

[Marco Pesenti Gritti <mpeseng tin it>]

On Mon, 2003-05-12 at 19:07, Marco Pesenti Gritti wrote:
> On Mon, 2003-05-12 at 18:58, Mike wrote:
> > On Mon, 2003-05-12 at 08:31, Alexander Larsson wrote:
> > > On Sun, 2003-05-11 at 23:10, Mike wrote:
> > > > mailto is not working. I set internet service mailto to evolution "%u",
> > > > but nothing happens when I click on mailto links.
> > > 
> > > The whole "prefered apps for some uris" system is going through some
> > > changes. This is probably the cause of this. Where did you click on the
> > > mailto link?
> > 
> > I have a mailto on my home page www.redtux.demon.co.uk
> > I have tested this in galeon and epiphany with the same results
> > 
> 
> It's possibly a galeon/epiphany bug, but I think something wrong also in
> file types capplet. I'm looking at this now ...
> 

Ok so it was partially epiphany fault. I fixed that in cvs.

Still gnome_vfs_url_show was not behaving correctly because the file
types capplet doesnt set the "enabled" gconf key when adding services.
Could someone more familiar then me with that code check if the patch is
correct ?

Thanks

Marco

Index: service-info.c
===================================================================
RCS file: /cvs/gnome/gnome-control-center/capplets/file-types/service-info.c,v
retrieving revision 1.20
diff -u -r1.20 service-info.c
--- service-info.c	30 Apr 2003 19:36:07 -0000	1.20
+++ service-info.c	12 May 2003 17:57:04 -0000
@@ -207,12 +207,17 @@
 	}
 
 	set_bool (info, "type", info->run_program);
+	set_bool (info, "enabled", TRUE);
 }
 
 void
 service_info_delete (const ServiceInfo *info)
 {
 	gchar *tmp;
+
+	tmp = get_key_name (info, "enabled");
+	gconf_client_unset (gconf_client_get_default (), tmp, NULL);
+	g_free (tmp);
 
 	tmp = get_key_name (info, "type");
 	gconf_client_unset (gconf_client_get_default (), tmp, NULL);