Re: patch to tasklist and libwnck

[textshell <textshell neutronstar dyndns org>]

On Saturday 11 May 2002 18:48, Thomas Vander Stichele wrote:
> Here are two patches that fix an issue I had with my sliding panel, namely
> the tasklist applet not showing up because the size request doesn't take
> into account that the panel can shrink to accomodate it.  These patches
> are against a pretty recent CVS.
>

I made a similar patch as my 2nd patch(no gone in till now). It's attached to
http://bugzilla.gnome.org/show_bug.cgi?id=80233
But as I learned a lot it isn't too bad that somebody else did it also ;-).

My patch just has a option for a fixed size. And my code doesn't yet work for 
edgepanels (seeing your code, most likly a trivial fix).

Did you file a bug for that problem? In that case we could have avoided 
duplicate work (got some other bugs i'd like to fix).

> It also adds these two prefs to the ui, and that's why I'm posting it
> here so this patch can make it in for the string and ui freeze.
>

Would be the same for my patch.

> Let me know if this is useful and ok to commit.  And don't spare me just
> because this is my first gnome patch ;)
>

Does your patch handle the problem that a window list applet on a vertical 
float/sliding panel starts up with only the handle. It would be nice if this 
case would work reasonable without a "please unbreak me" option[1].


But one of these patches should go in before Gnome 2.0.0 is released, it 
doesn't matter for me which one (or a fix of one, or...)

Now it's time for one of the folks that can commit or review these patches.

Martin H.


[1] this is a Havoc phrase.