gnome-wm patch

[Olivier Chapuis <olivier chapuis free fr>]

Hello,

I saw this sentence in gnome-session/gnome-session/gnome-wm
(current cvs head):

#FIXME: add all other windowmanagers here with their proper options

so here the fix for fvwm: add |fvwm|fvwm2 to the enlightenment|twm
case (note that the fvwm executable has been renamed to fvwm in the
devel version of fvwm). I do not think a patch is needed for this
(the attached patch contains more changes to gnome-wm). This is
an obvious change and a bug fix, so I hope that this change will
be applied ...

However, I've noted that it is not possible to start properly a
window manager with some options (e.g., I want fvwm to read
a special config file when I start it under gnome-session, so
if I well understand, the first time I start gnome-session for
this propose I need to export WINDOW_MANAGER to "fvwm -f gnomerc"
and start gnome-session as "gnome-session --choose-session=foo-fvwm"). 

The attached patch solved this problem (maybe only $WM_NAME should
be passed to gconf and note $WINDOW_MANAGER). This may be considered
as a bug fix patch?

BTW, fvwm-2.5.1 should work not so bad as a GNOME2 wm, as
fvwm-2.5.2 (not yet released) should work pretty well (these
are unstable versions).

Regards, Olivier

--- gnome-wm.orig	Tue May  7 08:11:23 2002
+++ gnome-wm	Tue May  7 12:19:03 2002
@@ -64,15 +64,22 @@
   WINDOW_MANAGER=xterm
 fi
 
+# extract the WM name (remove the options and the path)
+WM_NAME=
+for opt in $WINDOW_MANAGER ; do
+  WM_NAME=`basename $opt`
+  break;
+done
+
 # Now create options OPT1 and OPT2 based on the windowmanager used
 OPT1=
 OPT2=
 if [ ! -z "$SMID" ] ; then
-  case `basename $WINDOW_MANAGER` in
+  case "$WM_NAME" in
     sawfish|sawmill|metacity)
       OPT1=--sm-client-id=$SMID
       ;;
-    enlightenment|twm)
+    enlightenment|twm|fvwm|fvwm2)
       OPT1=-clientId
       OPT2=$SMID
       ;;
@@ -81,7 +88,7 @@
 fi
 
 # Store the selected WM so the wm-properties-capplet can find it
-gconftool-2 -t string -s "/desktop/gnome/applications/window_manager/default" $WINDOW_MANAGER
+gconftool-2 -t string -s "/desktop/gnome/applications/window_manager/default" "$WINDOW_MANAGER"
 
 exec $WINDOW_MANAGER $OPT1 $OPT2