Re: intltool rule patch
- From: Jody Goldberg <jody gnome org>
- To: jacob berkman <jacob ximian com>
- Cc: Darin Adler <darin bentspoon com>, Kenneth Christiansen <kenneth gnu org>, desktop-devel-list <desktop-devel-list gnome org>
- Subject: Re: intltool rule patch
- Date: Fri, 15 Mar 2002 16:37:29 -0500
On Fri, Mar 15, 2002 at 03:12:30PM -0500, jacob berkman wrote:
>
> - INTLTOOL_DESKTOP_RULE='%.desktop: %.desktop.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_MERGE) $(top_srcdir)/po $< [$]@ -d -u -c $(top_builddir)/po/.intltool-merge-cache'
> + INTLTOOL_DESKTOP_RULE='%.desktop: %.desktop.in ; $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_MERGE) $(top_srcdir)/po $< [$]@ -d -u -c $(top_builddir)/po/.intltool-merge-cache'
Ok so you are proposing to replace piles of
%.a : %.b commands
with
%.a : %.b ; commands
That is correct for gmake, but I don't know how portable it is.
The existing rules are not terribly portable though. Why use
$(wildcard) ? The command is run in a shell. Just use the builtin
wildcarding.
eg
INTLTOOL_DESKTOP_RULE='%.desktop: %.desktop.in ; $(INTLTOOL_MERGE) $(top_srcdir)/po/*.po ; $(INTLTOOL_MERGE) $(top_srcdir)/po $< [$]@ -d -u -c $(top_builddir)/po/.intltool-merge-cache'
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]