[patch] GnomeAbout

[Jens Finke <jens triq net>]

Hi,

attached is a patch to GnomeAbout which changes the following two things:

1. Don't invert the list of persons. This really sucks when you set an
ordered author list and they get displayed in reverse order.

2. Display all authors in one row if there are less than
MAX_ROWS_PER_COLUMN authors. IMHO the current algorithm looks good if
there are a lot authors but is quit ugly when there are only few persons
involved.

May I commit?

Regards,

   Jens

-- 
"Wer die Freiheit aufgibt, um Sicherheit zu gewinnen, wird am Ende beides
verlieren." -- Benjamin Franklin

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/ChangeLog,v
retrieving revision 1.1765
diff -u -p -r1.1765 ChangeLog
--- ChangeLog	2001/12/28 20:48:27	1.1765
+++ ChangeLog	2002/01/02 12:31:43
@@ -1,3 +1,10 @@
+2002-01-02  Jens Finke <jens triq net>
+
+	* gnome-about.c (gnome_about_draw_names): Use only one row if
+	there are less than MAX_ROWS_PER_COLUMN authors/documentors.
+	(gnome_about_set_persons): Don't invert the list of persons when
+	creating internal data structure.
+
 2001-12-28  jacob berkman  <jacob ximian com>
 
 	* gnome-vfs-util.h: gnome-vfs-types.h is deprecated, use
Index: gnome-about.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-about.c,v
retrieving revision 1.96
diff -u -p -r1.96 gnome-about.c
--- gnome-about.c	2001/12/27 01:27:07	1.96
+++ gnome-about.c	2002/01/02 12:31:43
@@ -609,8 +609,10 @@ gnome_about_draw_names (GnomeAbout *abou
 	pango_font_metrics_unref (metrics);
 
 	rows_per_column = gnome_about_get_number_of_undisplayed_entries (about);
-	rows_per_column = rows_per_column / 2 + rows_per_column % 2;
-	rows_per_column = MIN (rows_per_column, MAX_ROWS_PER_COLUMN);
+	if (rows_per_column > MAX_ROWS_PER_COLUMN) {
+		rows_per_column = rows_per_column / 2 + rows_per_column % 2;
+		rows_per_column = MIN (rows_per_column, MAX_ROWS_PER_COLUMN);
+	}
 
 	x = 170;
 	y = 85;
@@ -1021,7 +1023,7 @@ gnome_about_set_persons (GnomeAbout *abo
 
 		g_assert (&value_array->values[i] == value_array->values + i);
 		
-		list = g_slist_prepend (list, entry);
+		list = g_slist_append (list, entry);
 	}
 
 	switch (prop_id) {