Re: clock instant-apply patch



On Fri, Feb 22, 2002 at 11:11:12AM -0500, Jonathan Blandford wrote:
> Havoc Pennington <hp redhat com> writes:
> 
> > John Fleck <jfleck inkstain net> writes:
> > > On Fri, Feb 22, 2002 at 03:53:29AM +0200, Gediminas Paulauskas wrote:
> > > > Pr, 2002-02-18 18:07, fflewddur rašė:
> > > > > this patch updates the clock applet's properties dialog to use
> > > > > instant-apply settings.  could someone review/commit?  thanks!
> > > > 
> > > > This patch breaks UI freeze (but fortunately, not string freeze), but
> > > > without it this applet is inconsistent with all other dialogs in
> > > > gnome-panel, and is an improvement from usability POV.
> > > > 
> > > 
> > > This would require redoing the docs. I vote against it for that
> > > reason.
> > > 
> > 
> > Let's be sure the change is in bugzilla to go in right after release,
> > though.
> 
> Would a patch that also included a fix to the docs be accepted?  I don't
> see why a sufficiently motivated person couldn't get this in?
> 

Absolutely, Jonathan, that's a very good point.

Cheers,

John



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]