Re: Fix for GaimLog.Striptags()



On Wed, 2004-09-22 at 00:39 -0700, Arun Raghavan wrote:
> Hi,
> The GaimLog.StripTags() method loops forever if a line in the log has a
> "<" that isn't matched by a ">". Here's a one-liner to fix this - it
> retains the rest of the line starting at the unmatched "<".
> 
> One concern here is that we're ignoring everthing in between "<" and
> ">", which is not good. A line like:
> 
> ------------------------
> dude1: e < mc^2+1. I *really* want the text here indexed. e > mc^2+1
> dude2: Cool! I want that indexed too!
> ------------------------
> 
> would be reduced to:
> 
> ------------------------
> dude1: e  mc^2+1
> dude2: Cool! I want that indexed too! But I can't. I'm so unhappy.
> ------------------------
> 
> Maybe a patch to Gaim to write "<" and ">" when input by the user as
> "&lt;" and "&gt;" would be good. Any foreseeable objections from the
> Gaim folks?

Yeah, that's a serious problem.  I'll commit this, if you go ahead and
talk to the Gaim folks about outputting more sensible logs.

Nat




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]