Re: [Cowbell] [PATCH] Make GladeWindow a subclass of Gtk.Window



Hi Eskil,

> Here's a patch to make GladeWindow a subclass of Gtk.Window. I also
> added a new class GladeDialog, that's a subclass of Gtk.Dialog.

I don't like your manipulation of Window.Raw here.  If gtk# decides to
change the way it handles this, we could be in big trouble.  However, I
do like a few of your MainWindow modifications, so I've committed those
changes in svn.

In future patches however, can you make sure that the patch just deals
with one atomic change?  Its much easier to review and commit this way.

Thanks,

-Brad

-- 
Brad Taylor
Genome Software LLC
http://www.getcoded.net

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]