Re: Patch for review: timeout audio alarms

Hello Russell,

   The timeout alarm patch seems fine.  I would like to suggest that
   you add some error checking for making sure that the user does not
   enter invalid values for the timeout values and to make sure that
   the information we fetch from the configuration file is also
   within a reasonable range.

   In general, if this is not done in the rest of the code, it should
   be done.

Best wishes,

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]