Re: Proposed patch to the End of Recurrence problem

["Charles R. Tersteeg" <aa0na arrl net>]

Would this be the best fix?

Would this impact on anything else?

my 2¢ worth,
Chuck

Eskil Heyn Olsen wrote:

> Oy...
>
> This patch fixes the bug in "End on date" recurrence in gnomecal. The
> problem was, that the last day was "lost". Problem is, that the rrule has
> time T000000, and the event eg. T140000. Thus the comparison function in
> calobj.c misses the last day as !(000000 > 140000).
>
> To fix, during parsing of the enddate, I add 86400 secs (1 day).
>
> Comments or can I commit ?
>
> Index: calobj.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-pim/gncal/calobj.c,v
> retrieving revision 1.57
> diff -r1.57 calobj.c
> 403a404
> >       g_message("enndate = %s",*str);
> 405c406,409
> <               o->recur->_enddate = time_from_isodate (*str);
> ---
> >               /* As the rrule has T000000 as hour:min stamp, we add
> >                  86400 secs to make the rrule end at the end-of-
> >                  day, instead of beginning-of-day */
> >               o->recur->_enddate = time_from_isodate (*str) + 86400;
>
> /dev/eskil
> ---
>
> --
>         FAQ: Frequently-Asked Questions at http://www.gnome.org/gnomefaq
>          To unsubscribe: mail calendar-list-request@gnome.org with
>                        "unsubscribe" as the Subject.
begin:vcard 
n:Tersteeg;Charles R.
x-mozilla-html:TRUE
adr:;;;;;;
version:2.1
email;internet:aa0na@arrl.net
note;quoted-printable:icq# 15315331=0D=0Ahttp://cyberways.tripod.com=0D=0A
x-mozilla-cpt:;0
fn:Charles R. Tersteeg
end:vcard