Re: check.h seems to be missing on the build-slave still

[Iago Toral <itoral igalia com>]

Hi Stefan, 

the problem is that autogen.sh script is being run with --disable-tests
from moduleset. Look:

$ jhbuild
--moduleset=http://svn.gnome.org/svn/jhbuild/trunk/modulesets/gnome-2.20.modules --no-interact buildone gstreamer

*** Checking out gstreamer *** [1/1]

cvs -z3 -q -d :pserver:anoncvs anoncvs freedesktop org:/cvs/gstreamer
checkout -P -A gstreamer
U gstreamer/.cvsignore
U gstreamer/AUTHORS
...
U common/m4/gtk-doc.m4
U common/m4/pkg.m4
*** Configuring gstreamer *** [1/1]

./autogen.sh -- --prefix /usr/local/buildslave/gnome/work/bin --libdir
'${exec_prefix}/lib64' --disable-tests --disable-static
--disable-gtk-doc
+ options passed to configure:
--prefix /usr/local/buildslave/gnome/work/bin --libdir
${exec_prefix}/lib64 --disable-tests --disable-static --disable-gtk-doc
...

That --disable-tests is not in my .jhbuildrc file, of course :)

I tried to add --enable-tests to .jhbuildrc for gstreamer and it seems
to work, but having both --disable-tests and --enable-tests as
parameters for autogen.sh is quite confusing :). You can see the results
here:

http://build.gnome.org:8080/gstreamer/
http://build.gnome.org:8080/gstreamer/gstreamer-RHEL5/builds/26/step-gstreamer%20make-check.sh/1


I think gstreamer should not build tests by default, thus get rid of
--disable-tests from modulesets and instead it should only build tests
when --enable-tests is provided explicitly. What do you think?

Btw, you can get a much better tests summary if you enable verbose
output in check (that way we can extract the unit tests executed in each
test program and the broken assertion for those that have failed). Take
a look here to see what I mean:

http://blogs.igalia.com/itoral/?p=29

In order to enable verbose mode you can add this to the Makefile.am (in
case you're not setting verbosity level explicitly in your tests code):

CK_VERBOSITY=verbose

Iago

On Sun, 2007-10-28 at 17:18 +0200, Stefan Kost wrote:
> hi,
> 
> Stefan Kost schrieb:
> > hi,
> > 
> > could someone with access please install check >= 0.9.2 on the buildslaves?
> > 
> > Stefan
> 
> olav thanks for installing check. Its there but somehow is not getting used. Is
> there a way to login on that machine?
> 
> gstreamer build should show dozen of tests and not just 8 (non check based tests)
> http://build.gnome.org:8080/gstreamer/
> 
> The log
> http://build.gnome.org:8080/gstreamer/gstreamer-RHEL5/builds/21/step-gstreamer%20build/0
> indicates that configure is happy:
> 
> checking for check named check_pic  - version >= 0.9.2... no
> *** Could not run check test program, checking why...
> *** The test program failed to compile or link. See the file config.log for
> *** the exact error that occured.
> checking for check named check  - version >= 0.9.2... yes
> configure: CHECK_CFLAGS:
> configure: CHECK_LIBS:  -lcheck
> 
> Still when running make or make check, it does not enter gstreamer/tests/check.
> This can only be due to HAVE_CHECK=false for automake (see
> gstreamer/tests/Makefile.am).
> 
> If logging in is not possible, could I get the config.log from the build-slave?
> Could we add a link to the buildbox waterfall page to be able to fetch config.log?
> 
> Stefan
> 
> _______________________________________________
> Build-brigade-list mailing list
> Build-brigade-list gnome org
> http://mail.gnome.org/mailman/listinfo/build-brigade-list
>