Re: Current status of OpenBSD BEAST

[Tim Janik <timj gtk org>]

On Sun, 28 Dec 2003, Nedko Arnaudov wrote:

> I'm currently working on making BEAST buildable and runnable on
> OpenBSD. This status of my current work.

good.

> openbsd.txt contains HOWTO and TODO
> other files are patches that should be applied according to openbsd.txt

hm, the patches you sent seem to be in an early stage still, though that's
prolly a good point to comment on them ;)

> diff beast/docs/Makefile.am beast+/docs/Makefile.am
> --- beast/docs/Makefile.am	Sun Sep 21 03:35:59 2003
> +++ beast+/docs/Makefile.am	Sat Dec 27 20:48:16 2003
> @@ -1,4 +1,4 @@
> -SUBDIRS = generated
> +SUBDIRS = # generated
>
>  texi_docs = $(strip								\
>  	WRITING.3.texi			beast-index.texi	faq.texi	\

please figure what breaks upon building docs. i can't simply disable
doc generation in CVS if it's not working on your system.

> diff beast+/bse/bsemididevice-oss.c beast++/bse/bsemididevice-oss.c
> --- beast+/bse/bsemididevice-oss.c	Mon Aug 25 18:13:14 2003
> +++ beast++/bse/bsemididevice-oss.c	Sat Dec 27 12:39:42 2003
> @@ -27,7 +27,7 @@
>  BSE_DUMMY_TYPE (BseMidiDeviceOSS);
>  #else   /* BSE_MIDI_DEVICE_CONF_OSS */
>
> -#include	<sys/soundcard.h>
> +#include	<soundcard.h>
>  #include	<sys/ioctl.h>
>  #include	<sys/types.h>
>  #include	<sys/time.h>

this will break on linux. you actually want to add a check to configure.in
here, and then define something like SOUNDCARD_H which can be used for these
include statements (let it default to <sys/soundcard.h> if <soundcard.h>
wasn't found, so things still work on linux).

> diff beast+/bse/bsepcmdevice-oss.c beast++/bse/bsepcmdevice-oss.c
> --- beast+/bse/bsepcmdevice-oss.c	Mon Aug 25 18:13:14 2003
> +++ beast++/bse/bsepcmdevice-oss.c	Sat Dec 27 12:40:02 2003
> @@ -25,7 +25,7 @@
>  BSE_DUMMY_TYPE (BsePcmDeviceOSS);
>  #else   /* BSE_PCM_DEVICE_CONF_OSS */
>
> -#include	<sys/soundcard.h>
> +#include	<soundcard.h>
>  #include	<sys/ioctl.h>
>  #include	<sys/types.h>
>  #include	<sys/time.h>

see above.

> diff beast+/sfi/sfifilecrawler.c beast++/sfi/sfifilecrawler.c
> --- beast+/sfi/sfifilecrawler.c	Mon Oct 27 20:58:13 2003
> +++ beast++/sfi/sfifilecrawler.c	Sat Dec 27 12:35:06 2003
> @@ -581,7 +581,7 @@
>                 gboolean     use_fallbacks)
>  {
>    struct passwd *p = NULL;
> -  if (user && 1 /* getpwnam_r check */)
> +  if (user && 0 /* getpwnam_r check */)
>      {
>        char buffer[8192];
>        struct passwd spwd;

similar to soundcard.h, the patch here should check for getpwnam_r() in
configure.in, and special case based on that.

> diff beast+/tests/cxxbinding.cc beast++/tests/cxxbinding.cc
> --- beast+/tests/cxxbinding.cc	Wed Dec 24 19:59:08 2003
> +++ beast++/tests/cxxbinding.cc	Sat Dec 27 18:54:35 2003
> @@ -18,6 +18,7 @@
>   */
>  #include "bsecxxapi.h"
>  #include <bse/bse.h>
> +#include <unistd.h>
>
>  static SfiGlueContext *bse_context = NULL;
>

can you add what warning/error you get exactly without unistd.h?
e.g. something like: #include <unistd.h> /* for exit() */

> diff beast/autogen.sh beast+/autogen.sh
> --- beast/autogen.sh	Wed Dec 24 19:59:48 2003
> +++ beast+/autogen.sh	Sat Dec 27 01:20:59 2003
> @@ -8,11 +8,12 @@
>  AUTOMAKE_VERSION=1.4
>  ACLOCAL=aclocal
>  AUTOCONF=autoconf
> -AUTOCONF_VERSION=2.50
> +AUTOCONF_VERSION=2.58

this affects a bunch of developers, i'd like to hear particular reasons
for upgrading the autoconf dependancy, i.e. did you make sure <2.58 breaks
for you, and if so, why?

>  AUTOHEADER=autoheader
>  GETTEXTIZE=glib-gettextize
>  INTLTOOLIZE=intltoolize
> -#LIBTOOL=libtool
> +LIBTOOLIZE=libtoolize
> +LIBTOOLIZE_VERSION=1.5
>  CONFIGURE_OPTIONS=--enable-devel-rules=yes
>
>  srcdir=`dirname $0`
> @@ -77,13 +78,16 @@
>  	echo "Get the source tarball at http://ftp.gnu.org/gnu/libtool";
>  	DIE=1
>  }
> +
>  # check for libtool
> -#$LIBTOOL --version >/dev/null 2>&1 || {
> -#	echo
> -#	echo "You need to have $LIBTOOL installed to compile $PROJECT."
> -#	echo "Get the source tarball at http://ftp.gnu.org/gnu/libtool";
> -#	DIE=1
> -#}
> +if $LIBTOOLIZE --version 2>/dev/null | grep -q '^libtoolize (GNU libtool) '`echo $LIBTOOLIZE_VERSION|sed -e 's/\./\\\\./g'`'$' ; then
> +	:	# all fine
> +else
> +	echo
> +	echo "You need to have GNU libtool version $LIBTOOLIZE_VERSION installed to compile $PROJECT."
> +	echo "Get the source tarball at http://ftp.gnu.org/gnu/libtool";
> +	DIE=1
> +fi

i don't quite see what the point here is, CVS already has
libtoolized files of version 1.5.

>
>  # sanity test aclocal
>  $ACLOCAL --version >/dev/null 2>&1 || {


libtool files:

> diff beast/config.guess beast+/config.guess
> --- beast/config.guess	Sat Oct 11 23:11:45 2003
> +++ beast+/config.guess	Thu Jan  1 02:00:00 1970
> @@ -1,1415 +0,0 @@
> -#! /bin/sh
> -# Attempt to guess a canonical system name.
> -#   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
> -#   2000, 2001, 2002, 2003 Free Software Foundation, Inc.
> -
> -timestamp='2003-10-07'
[...]

> diff beast/config.sub beast+/config.sub
> --- beast/config.sub	Sat Oct 11 23:11:45 2003
> +++ beast+/config.sub	Thu Jan  1 02:00:00 1970
> @@ -1,1510 +0,0 @@
> -#! /bin/sh
> -# Configuration validation subroutine script.
> -#   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
> -#   2000, 2001, 2002, 2003 Free Software Foundation, Inc.
> -
> -timestamp='2003-10-07'
[...]

> diff beast/ltconfig beast+/ltconfig
> --- beast/ltconfig	Thu Sep 27 14:56:47 2001
> +++ beast+/ltconfig	Thu Jan  1 02:00:00 1970
> @@ -1,3115 +0,0 @@
> -#! /bin/sh
[...]

> diff beast/ltmain.sh beast+/ltmain.sh
> --- beast/ltmain.sh	Wed Dec 17 15:15:05 2003
> +++ beast+/ltmain.sh	Thu Jan  1 02:00:00 1970
> @@ -1,6358 +0,0 @@
> -# ltmain.sh - Provide generalized library-building support services.
> -# NOTE: Changing this file will not affect anything until you rerun configure.
> -#
[...]

including these files in the diff really didn't help much.
if you meant to say that they should be removed from CVS,
a few words would have been more appropriate than sending
300k of "- ..." lines.

in any case, i'd like to hear why you did those libtool changes,
does the CVS 1.5 version not work for you, and your 1.5 version
does?

---
ciaoTJ