Re: [Banshee-List] A few things... (and you guys rock)

[Aaron Bockover <abockover novell com>]

There's a security flaw in concatenations like that. I'll look for the
bug number that explains it, but this is better:

if test -n "$MOZILLA_FIVE_HOME"; then
    export LD_LIBRARY_PATH=$MOZILLA_FIVE_HOME${LD_LIBRARY_PATH+:
$LD_LIBRARY_PATH}
fi

Basically, if LD_LIBRARY_PATH was not previously set, the ':' delimiter
will not be concatenated after $MOZILLA_FIVE_HOME

Trick: would you add this to your plugin?

--Aaron

On Sat, 2006-07-29 at 21:16 +0100, Michael Hutchinson wrote:
> On 7/29/06, Aaron Bockover <abockover novell com> wrote:
> > On Fri, 2006-07-28 at 17:15 -0400, Matt Philmon wrote:
> > > Cool! So... do we need to open a bug report and attach the "fix"?
> >
> > No, this is not an official plugin, it is not officially supported, I'd
> > really rather it not clog bugzilla.
> 
> This will be useful for any plugin that wants to use Gecko#. There
> isn't really any other way to use Gecko# on machines that have
> parallel versions of libgtkmozembed.so.
> 
> Could you at least add the following?
> 
> if test -n "$MOZILLA_FIVE_HOME"; then
> export LD_LIBRARY_PATH=$MOZILLA_FIVE_HOME:$LD_LIBRARY_PATH
> fi
>