Re: [Banshee-List] [PATCH] Audioscrobbler queue saving



On Mon, 2006-01-02 at 20:21 +0100, Ruben Vermeersch wrote:
> This patch makes sure no audioscrobbler submission data is lost if
> submission should fail.
> 
> It can be applied in parallel with audioscrobbler-seeking.diff, the seek
> detection patch I've mailed yesterday, there's no overlaps between the
> two.

Noticed a small bug:

if (queue.Count != 0) {
    WriteQueue ();  
}

Should just be:

WriteQueue ();

Else the queue will never be cleared when submission succeeded.

  Ruben


--
Ruben Vermeersch (rubenv)
http://www.Lambda1.be/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]