Re: [Banshee-List] One small patch

[Aaron Bockover <abockover novell com>]

This patch is mostly correct, however I'm holding off on committing it
because I can cause some inconsistency when searching/sorting.

Start playing a song, and then filter the view such that some songs will
go away, but the song you are playing will remain in the visible set.
The playing iter is not returned properly in your patched version. The
fix should be simple though.

I'll try to look at it quickly tomorrow, but it's off to bed for
tonight.

Cheers,
Aaron


On Tue, 2006-02-21 at 10:10 +0100, Oscar Forero wrote:
> Hello,
> 
> First I will like to ask Aaron if the Genre patch was like he want it, and send a new small patch, working on my
> normalized version i saw that there is a function in PlaylistModel.cs call SyncPlayingIter, it is call when update view
> is call and will iterate over the model until it finds the iterator for the song is being played at the moment, i think
> this is not the best way to do it, specially because the View will iterate over the whole model to render anyway.
> 
> So i made the function private, and modify the rendering function TrackCellInd ; it is i think and small a sure step,
> and will avoid unneeded iterations over the tracks. After this step i will see if the function can also be replaced for
> internal use.
> 
> >From what i can see banshee continuous to work correctly after this change. The main goal of this change is avoid the
> more spread use of that this function, which i think is dangerously inefficient. 
> 
> regards,
> 
> Oscar.
> _______________________________________________
> Banshee-list mailing list
> Banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list