[Banshee-List] [libipoddevice] mark some functions as static in ipod-device.c

[Christophe Fergeau <teuf gnome org>]

Hi,

The attached patch mark some functions internal to ipod-device.c as
static. Is it ok to commit ?

Christophe

? cleanup.diff
? cleanups.diff
? guint64.diff
? ipod-device-guint64.diff
? ipod-device-new.diff
? libipoddevice-artwork.diff
? libipoddevice.diff
? mkinstalldirs
? static.diff
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libipoddevice/ChangeLog,v
retrieving revision 1.48
diff -u -r1.48 ChangeLog
--- ChangeLog	20 Nov 2005 02:59:36 -0000	1.48
+++ ChangeLog	21 Nov 2005 20:20:28 -0000
@@ -1,3 +1,7 @@
+2005-11-21  Christophe Fergeau  <teuf gnome org>
+
+	* src/ipod-device.c: mark some internal functions as static
+
 2005-11-19  Miguel de Icaza  <miguel novell com>
 
 	* configure.ac: Probe for g_mkdir_with_parents
Index: src/ipod-device.c
===================================================================
RCS file: /cvs/gnome/libipoddevice/src/ipod-device.c,v
retrieving revision 1.45
diff -u -r1.45 ipod-device.c
--- src/ipod-device.c	20 Nov 2005 02:59:37 -0000	1.45
+++ src/ipod-device.c	21 Nov 2005 20:20:28 -0000
@@ -228,20 +228,20 @@
 static void ipod_device_init(IpodDevice *sp);
 static void ipod_device_finalize(GObject *object);
 
-gchar *ipod_device_read_device_info_string(FILE *fd);
-void ipod_device_write_device_info_string(gchar *str, FILE *fd);
+static gchar *ipod_device_read_device_info_string(FILE *fd);
+static void ipod_device_write_device_info_string(gchar *str, FILE *fd);
     
-gboolean ipod_device_reload(IpodDevice *device);
-void ipod_device_construct_paths(IpodDevice *device);
-gboolean ipod_device_info_load(IpodDevice *device);
-guint ipod_device_detect_model(IpodDevice *device);
-gboolean ipod_device_detect_volume_info(IpodDevice *device);
-LibHalContext *ipod_device_hal_initialize();
-void ipod_device_detect_volume_used(IpodDevice *device);
-gboolean ipod_device_has_open_fd(IpodDevice *device);
-gboolean ipod_device_read_sysinfo(IpodDevice *device);
-gboolean ipod_device_detect_writeable(IpodDevice *device);
-void ipod_device_restore_reboot_preferences(IpodDevice *device);
+static gboolean ipod_device_reload(IpodDevice *device);
+static void ipod_device_construct_paths(IpodDevice *device);
+static gboolean ipod_device_info_load(IpodDevice *device);
+static guint ipod_device_detect_model(IpodDevice *device);
+static gboolean ipod_device_detect_volume_info(IpodDevice *device);
+static LibHalContext *ipod_device_hal_initialize();
+static void ipod_device_detect_volume_used(IpodDevice *device);
+static gboolean ipod_device_has_open_fd(IpodDevice *device);
+static gboolean ipod_device_read_sysinfo(IpodDevice *device);
+static gboolean ipod_device_detect_writeable(IpodDevice *device);
+static void ipod_device_restore_reboot_preferences(IpodDevice *device);
     
 struct IpodDevicePrivate {
     LibHalContext *hal_context;

Attachment: signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=