[Banshee-List] Don't escape artist header twice
- From: Ruben Vermeersch <ruben Lambda1 be>
- To: banshee-list gnome org
- Subject: [Banshee-List] Don't escape artist header twice
- Date: Sun, 13 Nov 2005 22:29:05 +0100
Another trivial patch: It seems like the artist header is escaped for
entities twice, once in src/TrackInfoHeader.cs, once in
StringUtil.EntityEscape(). Is there a specific reason for doing this?
Doing this breaks artist names with an apostrof (') in the name.
Regards,
Ruben
--
Ruben Vermeersch (rubenv)
http://www.Lambda1.be/
Index: src/TrackInfoHeader.cs
===================================================================
RCS file: /cvs/gnome/banshee/src/TrackInfoHeader.cs,v
retrieving revision 1.11
diff -u -p -r1.11 TrackInfoHeader.cs
--- src/TrackInfoHeader.cs 8 Sep 2005 18:14:46 -0000 1.11
+++ src/TrackInfoHeader.cs 13 Nov 2005 21:25:22 -0000
@@ -116,8 +116,7 @@ namespace Banshee
public string Artist
{
set {
- artistLabel.Markup = "<b>" +
- GLib.Markup.EscapeText(StringUtil.EntityEscape(value)) + "</b>";
+ artistLabel.Markup = "<b>" + StringUtil.EntityEscape(value) + "</b>";
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]