Re: Small patch for irrelevant scrollbar issue

On 09/26/2005 10:15:13 PM Mon, Sebastian Zerbe wrote:
Hi folks,

attached is a little patch against balsa-2.3.5 which solves an issue with the preview scrollbars I found. The srollbars won't be removed when all mailboxes are closed. You can find a screenshot of what I mean here:

I can't think why it's never offended me--but you're right, it's an issue! Seems like a Gtk bug to me--surely a scrollbar should hide its controls when the widget it's scrolling is hidden.

Please do not feel offended by the strange mix of WinXP- and MacOS X-Themes I use on my system :-)

De gustibus... :-)

Thanks for the patch. Unfortunately, it doesn't completely solve the problem for me. I have "Automatically view message when mailbox opened" unchecked, and when I reopen a mailbox, the scrollbar reappears even though there's no message displayed.

I'm attaching an alternative fix, which seems to do it for me--could you check it out?


Index: src/main-window.c
RCS file: /cvs/gnome/balsa/src/main-window.c,v
retrieving revision 1.640
diff -u -r1.640 main-window.c
--- src/main-window.c	30 Jun 2005 16:24:53 -0000	1.640
+++ src/main-window.c	27 Sep 2005 14:18:14 -0000
@@ -4483,9 +4483,14 @@
     /* If we have a message, check that the message still has a mailbox;
      * if the mailbox was closed, this test will fail. */
-    if (!window->current_message || window->current_message->mailbox)
+    if (!window->current_message) {
+        balsa_message_set(BALSA_MESSAGE(window->preview), NULL);
+        gtk_widget_hide(window->preview);
+    } else if (window->current_message->mailbox) {
+        gtk_widget_show(window->preview);
+    }
     index = g_object_get_data(G_OBJECT(window), BALSA_INDEX_GRAB_FOCUS);
     if (index) {

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]