Re: replying to openpgp encrypted messages



Hi all!

Am 01.03.05 10:36 schrieb(en) Albrecht Dreß:
Well, I didn't try it, so it's not implemented... ;-) I think this is a
bug. I'll try to fix that...

...which is attached to this message, fixing this problem plus a few other ones. Details:

- libbalsa/gmime-part-rfc2440.c: when opening an OpenPGP encrypted message with a proper charset entry more than once, the filter to UTF-8 was added multiple times to the message stream, as the '2440 decrypt method already returned a filter stream. Fixed by writing the stream to a new (plain) stream.

- src/balsa-message.[hc]: rename libbalsa_msg_perform_crypto to balsa_message_perform_crypto, add a parameter to decrypt only and export the function. Move the checks for the ref count when decrypting to a more appropriate place to suppress the error popup when the action would actually succeed. For RFC 2440, a signature check changes the mime part stream, so don't do it if multiple instances are opened.

- src/sendmsg-window.c: call balsa_message_perform_crypto() to fix the bug Kacper reported.

Opinions?

Cheers, Albrecht.


--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 Albrecht Dreß  -  Johanna-Kirchner-Straße 13  -  D-53123 Bonn (Germany)
       Phone (+49) 228 6199571  -  mailto:albrecht dress arcor de
   GnuPG public key:  http://home.arcor.de/dralbrecht.dress/pubkey.asc
_________________________________________________________________________

Attachment: balsa-decrypt-patch-2005-03-02.gz
Description: GNU Zip compressed data

Attachment: pgpjyi25LA36m.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]