Re: Has anyone successfully built a x86_64 rpm from balsa-2.3.3-1.FC3.src.rpm on FC4?

[Willem Riede <wriede riede org>]

On 06/27/2005 01:24:18 PM, Pawel Salek wrote:
> On 06/27/2005 01:24:30 AM, Willem Riede wrote:
> > When I do that rpmbuild, install the resulting rpm and
> > run balsa, I get into trouble almost immediately:
> 
> Can you please try attached patch? It may be it...

I'm ecstatic to be able to report success - balsa as compiled
on my FC4 x86_64 system now runs without problem!

Thanks, Willem Riede.

PS - you asked earlier for gdb bt - it gave much the same traceback.


> Index: libbalsa/imap/imap-commands.c
> ===================================================================
> RCS file: /cvs/gnome/balsa/libbalsa/imap/imap-commands.c,v
> retrieving revision 1.68
> diff -u -r1.68 imap-commands.c
> --- libbalsa/imap/imap-commands.c	10 Jun 2005 20:47:58 -0000	1.68
> +++ libbalsa/imap/imap-commands.c	27 Jun 2005 17:23:19 -0000
> @@ -35,7 +35,7 @@
>  coalesce_seq_range(int lo, int hi, CoalesceFunc incl, void *data)
>  {
>    GString * res = g_string_sized_new(16);
> -  char buf[10], *str;
> +  char *str;
>    enum { BEGIN, LASTOUT, LASTIN, RANGE } mode = BEGIN;
>    int seq;
>    unsigned prev =0, num = 0;
> @@ -44,11 +44,11 @@
>      if(seq<=hi && (num=incl(seq, data)) != 0) {
>        switch(mode) {
>        case BEGIN: 
> -        sprintf(buf, "%u", num); g_string_append(res, buf); 
> +        g_string_append_printf(res, "%u", num);
>          mode = LASTIN; break;
>        case RANGE:
>          if(num!=prev+1) {
> -          sprintf(buf, ":%u,%u", prev, num); g_string_append(res, buf); 
> +          g_string_append_printf(res, ":%u,%u", prev, num);
>            mode = LASTIN;
>          }
>          break;
> @@ -58,7 +58,7 @@
>            break;
>          } /* else fall through */
>        case LASTOUT: 
> -        sprintf(buf, ",%u", num); g_string_append(res, buf); 
> +        g_string_append_printf(res, ",%u", num);
>          mode = LASTIN; break;
>        }
>      } else {
> @@ -67,7 +67,7 @@
>        case LASTOUT: break;
>        case LASTIN: mode = LASTOUT; break;
>        case RANGE: 
> -        sprintf(buf, ":%u", prev); g_string_append(res, buf); 
> +        g_string_append_printf(res, ":%u", prev);
>          mode = LASTOUT;
>          break;
>        }
> 
>