Re: [PATCH] static const field reassigned in pop3.c



On 02/20/2005 07:56:38 PM, Kacper Wysocki wrote:
Cheers all,

ever since the pop3s fix I've had trouble connecting to my non-ssl pop3 accounts. I finally got around to debugging it.

After a bit of figuring out, I discovered that my compiler (gcc 3.3.5) doesn't reinitialize static fields on subsequent calls. Not sure if that's ANSI C, didn't check. Either way, char *service should probably not be a static const.

Attached one-liner patch fixes the problem.

It certainly shouldn't be static--but it should probably still be const--committed as such--thanks for debugging that!

Peter




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]