Re: [PATCH] : More cleanups/improvments

[Pawel Salek <pawsa theochem kth se>]

On 2001.10.15 17:52 Emmanuel wrote:
> diff -u balsa-1.2.0/libbalsa/address-book-ldif.c
> test/balsa-1.2.0/libbalsa/address-book-ldif.c
> --- balsa-1.2.0/libbalsa/address-book-ldif.c	Sat Aug 25 01:22:41
> 2001
> +++ test/balsa-1.2.0/libbalsa/address-book-ldif.c	Mon Oct 15
> 16:29:33 2001
> @@ -637,8 +631,7 @@
>  	    gtk_object_ref(GTK_OBJECT(addr1));
>  	    resa = g_list_next(resa);
>  	    resb = g_list_next(resb);
> -	} else if (resa != NULL &&
> -		   (resb == NULL || address_compare(addr1, addr2) > 0) )
> {
> +	} else if (address_compare(addr1, addr2) > 0) {
>  	    res = g_list_prepend(res, addr1);
>  	    gtk_object_ref(GTK_OBJECT(addr1));
>  	    resa = g_list_next(resa);

I think this is wrong: what if one of resa or resb is NULL? 
address_compare will get a null pointer on input, and that would be an 
error.

Also, I have not quite understood the point of 
mutt_mktemp->libbalsa_mktemp transition?

/Pawel
-- 
Pawel Salek, Theoretical Chemistry, SCFAB, Stockholm
http://www.theochem.kth.se/~pawsa/