PATCH: various part 1



jo,

patch 1: balsa/src/balsa-index.c

there was an fixme complaining about doing some
i18n stuff differently, dunno why it wasnt put into
the gchar array before but well here the patch.
ITWORKSFORME (tm)

patch 2: balsa/src/address-book-config.c

some strings wasnt put into language definition
i18n stuff. ITWORKSFORME (tm)

patch 3: balsa/src/balsa-mblist.c balsa/src/balsa-index.c

this patch is not everyones taste but lemme explain.
if you look at the left where you see all your mailbox
ordered in the clist from top to bottom then you realize
that whenever you press one item and it gets marked with
the selectionmark, the pixmap behind it will have cutting
edges. now if you think this through, you realize that
the space of the clist rows is usually 16 pixels, so are
the graphic elements. i increased this to 18 pixels so
the elements are getting some space. a major disadvantage
is that this enlargens the clist tree a bit. a major
advantage may be, that the readability increases with this
you have a clearer better overview of the stuff in the
window. ITWORKSFORME (tm)

-- 
Name....: Ali Akcaagac
Status..: Student Of Computer & Economic Science
E-Mail..: mailto:ali.akcaagac@stud.fh-wilhelmshaven.de
WWW.....: http://www.fh-wilhelmshaven.de/~akcaagaa
--- balsa-cvs/src/balsa-index.c	Wed Oct 17 13:57:43 2001
+++ balsa/src/balsa-index.c	Wed Oct 17 14:26:34 2001
@@ -276,21 +276,15 @@
      * attachments
      */
     static gchar *titles[] = {
-	"#",
-	"S",
-	"A",
-	NULL,
-	NULL,
-	NULL,
-	NULL
+	N_("#"),
+	N_("S"),
+	N_("A"),
+	N_("From"),
+	N_("Subject"),
+	N_("Date"),
+	N_("Size")
     };
 
-    /* FIXME: */
-    titles[3] = _("From");
-    titles[4] = _("Subject");
-    titles[5] = _("Date");
-    titles[6] = _("Size");
-
     bindex->mailbox_node = NULL;
     adj = gtk_adjustment_new (0.0, 0.0, 10.0, 1.0, 1.0, 1.0);
     gtk_scrolled_window_set_hadjustment (GTK_SCROLLED_WINDOW (bindex), 
--- balsa-cvs/src/address-book-config.c	Wed Oct 17 13:57:43 2001
+++ balsa/src/address-book-config.c	Wed Oct 17 14:33:33 2001
@@ -364,7 +364,7 @@
 
     abc->ab_specific.vcard.path =
 	gnome_file_entry_new("VCARD ADDRESS BOOK PATH",
-			     "Select path for address book");
+			     _("Select path for address book"));
     gtk_table_attach(GTK_TABLE(table), abc->ab_specific.vcard.path, 1, 2,
 		     1, 2, GTK_EXPAND | GTK_FILL, GTK_FILL, 0, 10);
 
@@ -408,7 +408,7 @@
 
     abc->ab_specific.ldif.path =
 	gnome_file_entry_new("LDIF ADDRESS BOOK PATH",
-			     "Select path for address book");
+			     _("Select path for address book"));
     gtk_table_attach(GTK_TABLE(table), abc->ab_specific.ldif.path, 1, 2,
 		     1, 2, GTK_EXPAND | GTK_FILL, GTK_FILL, 0, 10);
 
--- balsa-cvs/src/balsa-index.c	Wed Oct 17 13:57:43 2001
+++ balsa/src/balsa-index.c	Wed Oct 17 15:02:53 2001
@@ -325,10 +325,10 @@
     gtk_clist_set_column_width(clist, 5, balsa_app.index_date_width);
     gtk_clist_set_column_width(clist, 6, balsa_app.index_size_width);
     font = gtk_widget_get_style (GTK_WIDGET(clist))->font;
-    row_height = font->ascent + font->descent+2;
+    row_height = font->ascent + font->descent + 2;
     
-    if(row_height<16) /* pixmap height */
-	gtk_clist_set_row_height(clist, 16);
+    if(row_height < 18) /* pixmap height 16 + 2 pixel space */
+	gtk_clist_set_row_height(GTK_CLIST(clist), 18);
 
     /* Set default sorting behaviour */
     gtk_clist_set_sort_column(clist, 5);
--- balsa-cvs/src/balsa-mblist.c	Wed Oct 17 13:57:43 2001
+++ balsa/src/balsa-mblist.c	Wed Oct 17 15:02:59 2001
@@ -490,10 +490,10 @@
 
     style = gtk_widget_get_style (GTK_WIDGET (tree));
     font = style->font;
-    text_height = font->ascent + font->descent+2;
+    text_height = font->ascent + font->descent + 2;
 
-    if(text_height < 16) /* pixmap height */
-	gtk_clist_set_row_height (GTK_CLIST (tree), 16);
+    if(text_height < 18) /* pixmap height 16 + 2 pixel space */
+	gtk_clist_set_row_height(GTK_CLIST(tree), 18);
 
     gtk_clist_set_column_width(GTK_CLIST(tree), 0,
 			       balsa_app.mblist_name_width);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]