Re: Patch: Multipart support for reply/quote message



On 2001.10.10 12:43 Toralf Lund wrote:
> Here is another patch that is somewhat related to the ones for inclusion 
> of messages. It updates the "quote message" logic so that it will do (at 
> least nearly) the right thing for multi-part messages, i.e.:

1. I understand that this patch partially deprecates
http://bugzilla.gnome.org/show_bug.cgi?id=58915
right?

2. I would rather use a function similar to following for 
html_entity_to_char conversion:

--- cut here ----------
const struct {
   const char * entity;
   int character;
} entity_table[] = {
  {"lt", '<'},
  {"gt", '>'},
  ....
};

    for(i=0; i<ELEMENTS(entity_table); i++)
       if(g_strcasecmp(entity_table[i].entity, char_ref) ==0)
           return entity_table[i].character;
...
}
----- cut here ------------
This is much less error-prone and more cache-friendly.

/Pawel
-- 
Pawel Salek, Theoretical Chemistry, SCFAB, Stockholm
http://www.theochem.kth.se/~pawsa/




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]