Re: [PATCH] mailbox tree

[christophe barbe <christophe barbe online fr>]

Here is the previous mblist patch slightly modified.
The tree widget still saves the width of his parent (which is a mistake)
but now, in both use of mblist, parents (in the main window and in the
right click menu) have the same properties (the Scroll widget is
automatic).

The real fix should be to avoid to save the parent width on a children
resize event. Unfortunately it sounds not so simple and we should use this
patch in the mean time.

So please, apply this little patch to cvs. 

Christophe

Le 2001.07.09 17:04:15 +0200, christophe barbé a écrit :
> The patch is buggy. Each time the in-menu mblist is displayed, the width
> is
> saved with the correct value + the witdh of the scrollbar (if present).
> 
> A better solution could be to avoid saving the width of the tree widget
> when created for the right click menu. 
> 
> Another solution could be to not saved the parent width which is the
> problem source. I think this is a design mistake to save from a children
> the width of its parent window.
> 
> I will try to do a better patch for this bug.
> 
> Christophe
> 
> Le sam, 07 jui 2001 16:00:47, christophe barbe a écrit :
> > Hi,
> > 
> > I attach to this mail a little patch which solves the following problem
> :
> > 
> > The problem is visible only when you don't display mails count in your
> > mailbox tree.
> > You adjust the width of your mb list to fit your mailbox names.
> > If you right click on a message and select the transfer entry, the
> mblist
> > is displayed as a sub-menu, but with  a default width (because the gtk
> > tree
> > widget don't suggest the size of his column when there's only one,
> that's
> > why the bug is not visible when you display mails count). And worst,
> the
> > default width is then saved (by allocate_cb) as the user choice. Then
> if
> > you restart balsa, the mblist on the main window use this default
> width. 
> > 
> > The solution, the simplest and IMHO the correct one, is to set the
> width
> > of the in-menu mblist with the user choice. 
> > 
> > Christophe
> > 
> 
> _______________________________________________
> balsa-list mailing list
> balsa-list@gnome.org
> http://mail.gnome.org/mailman/listinfo/balsa-list
> 
-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

mblist-new.patch