Re: Balsa + libESMTP + TLS

[christophe barbe <christophe barbe ml online fr>]

Le 2001.08.28 11:38:07 +0200, Pawel Salek a écrit :

> Speaking of bugs and fixes, there are still some bugs that well, bug me.
> In particular, there should be a sanity check for default indentity so
> we can avoid bugs like 
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=58834
> or
> http://bugzilla.gnome.org/show_bug.cgi?id=59612
> 
> This should be fairly simple, grep current_ident */*.c would do most of
> the job. This would list a fields that are assumed to be not-NULL. 
> Then, the integrity of the default identity has to be assured on any
> change of it. That's all. (I shyly ask: any volunteers? ;-)

I've in mind some changes to the identity stuff that are IMHO required.
This should fix all problems of undefined field.
The main idea is to use the same structure (identity) for all defaults
values that are in the preferences dialog box and that are also specified
in identities.

This structure (the ID 0) will not be show in the Identities DBox.

Then all code using an per-identity setting will do something like
	if (defined(Id[i]->mysetting)) {
		myset=Id[i]->mysetting;
	} else {
		myset=Id[0]->mysetting;
	}

The code will be more clean and readable.

This is something I would like to do before doing the multi-smtp server
stuff (Id based).
I believe that Identities should be disabled by default in 1.2 or at least
marked as incomplete stuff (I don't remember the exact name but I refer
here to the configure option).

Christophe

> 
> On 2001-08-25 18:32 Brian Stafford wrote:
> > I've redone the TLS patch to add full blown SMTP STARTTLS support to
> > Balsa. This is against CVS of 25/Aug/2001.
>  
> -- 
> Pawel Salek (pawsa@theochem.kth.se) http://www.theochem.kth.se/~pawsa/
> Theoretical Chemistry Division, KTH voice: +46 8 790-8202
> 
> _______________________________________________
> balsa-list mailing list
> balsa-list@gnome.org
> http://mail.gnome.org/mailman/listinfo/balsa-list
> 
-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E