Re: GnomeCard, AddressBook fixes.

[Pawel Salek <pawsa TheoChem kth se>]

On 2001-08-15 12:15 Ali Akcaagac wrote:
> during my exercise through the balsa code, i've detected
> something strange that should really get fixed as soon
> as possible so here the patch.

The patch looks OK, I have just one comment on style: calling strlen()
to check is string is empty is a bad habit, str[0] == '\0' is a much
fastest test, particularly for non-empty strings (I know it does not
matter much in this particular case, but good style is a good style).

I am looking forward to other comments (if there are none I will commit
this patch after some further testing).

/Pawel

PS. I wish all the patches were so thoroughly described :-). Thanks!

> 
> now some serious facts:
> 
> [point 1]-----------------------------------------------
> 
> the 'store to addressbook' and some of the vcard options
> in the code are broken for a longer period now and i took
> the time to fix all of them.
> 
> if you click on an email and want to store the address, the
> organisation field has no function, the data inside it doesn't
> get transmitted to the address structure and never gets saved
> in either gnomecard, ldap or whatever. with other words it was
> simply not present.
> [snip]
-- 
Pawel Salek (pawsa@theochem.kth.se) http://www.theochem.kth.se/~pawsa/
Theoretical Chemistry Division, KTH voice: +46 8 790-8202