balsa 1.0pre3 crashes and bugs

[Matthias Andree <matthias andree stud uni-dortmund de>]

Since bugs.gnome.org plays dead machine currently, I'm reporting the
bugs here:

MOST SEVERE LAST!

1. spell checking does not work. Tries to open the "de" dictionary,
which is the wrong name, "deutsch" is the proper one (at least for
ispell)

2. crashes and burns on start

strace log, last lines:

stat("/home/emma/.gnome/balsa", {st_dev=makedev(3, 8), st_ino=208100,
st_mode=S_IFREG|0644, st_nlink=1, st_uid=500, st_gid=100,
st_blksize=4096, st_blocks=6, st_size=2155, st_atime=100/10/20-15:47:24,
st_mtime=100/10/20-13:58:20, st_ctime=100/10/20-13:58:20}) = 0
open("/home/emma/.gnome/balsa", O_RDONLY) = 10
fstat(10, {st_dev=makedev(3, 8), st_ino=208100, st_mode=S_IFREG|0644,
st_nlink=1, st_uid=500, st_gid=100, st_blksize=4096, st_blocks=6,
st_size=2155, st_atime=100/10/20-15:47:24, st_mtime=100/10/20-13:58:20,
st_ctime=100/10/20-13:58:20}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0)
= 0x130000
read(10, "\n[mailbox-Inbox]\nPath=/home/emma"..., 4096) = 2155
read(10, "", 4096)                      = 0
close(10)                               = 0
munmap(0x130000, 4096)                  = 0
time(NULL)                              = 972049665
--- SIGSEGV (Speicherzugriffsfehler) ---
+++ killed by SIGSEGV +++

backtrace:
#0  0x5c4711 in free () at malloc.c:2952
#1  0x518a0b in g_free () from /usr/lib/libglib-1.2.so.0
#2  0x80834a4 in config_mailboxes_init () at save-restore.c:217
#3  0x808302b in config_load () at save-restore.c:65
#4  0x807684b in config_init () at main.c:160
#5  0x8076b4b in main (argc=3, argv=0xbffff534) at main.c:285

Looks like it wants efence debugging or the like:

$ EF_PROTECT_BELOW=1 EF_FILL=85 EF_PROTECT_FREE=1 ef balsa \
  --disable-crash-dialog

ElectricFence Aborting: free(123970): address not from malloc().

save-restore.c, marking the offender with ">>": (first iteration)
 | 213                 config_mailbox_init(tmp);
 | 214                 g_free(tmp);
 | 215             }
 | 216             g_free(key);
>> 217             g_free(val);
 | 218         }
 | 219         return TRUE;                /* hm... check_basic_mailboxes?  */
 | 220     }                               /* config_mailboxes_init */

Commenting that line, EFence reports:
ElectricFence Aborting: free(bffff504): address not from malloc().

I'm giving up here, I'm not into balsa and GNOME so I'd waste my time
without outcome.

Please fix. Please also consider debugging with both dmalloc and efence
before releasing 1.0pre4 or 1.0pre5!

-- 
Matthias Andree