Re: API changes



On Fri, 2006-08-04 at 11:30 +0300, Dirk-Jan C. Binnema wrote:

Hey Dirk and co (adding the mailing list back in CC)
 
> > Do-I-Need-To-Change-It questions:
> > 
> > - Remove the Iface suffix each interface type has?
> > - Remove the Msg prefix of the mime-part type?
> > - Remove the Msg prefix of the header type?
> > - Rename *Msg* to *Message*?
> 
> If there are no strong reasons to change these things, why do so? The
> work the Modest-using code is not so much (and easier sed'able), and I'd
> be happy to change if there is a good reason to do so...
> 
> But if there isn't... well, let's keep it as it is, I'd say. 
> 
> Also note that s/Iface|_IFACE//g names are already taken in a lot of cases.

Right, replacing the Iface and _IFACE would basically mean having to
renaming all Camel and Gtk+ implementations. That's because I was so
stupid to give all my types a name without extra implementation info in
it.

For example: TnyMsg and not TnyCamelMsg implements TnyMsgIface. Renaming
TnyMsgIface means that it would conflict with the TnyMsg type.

Of course wouldn't the using-developer see TnyCamelMsg. It's hidden by
the TnyMsg(Iface) API. Not even its constructor is needed (unless you
are creating messages, but I'm considering creating a factory for that).

Still, I'm not against it. It's just a huge amount of monkey work which
I'm not going to do on my own (but I will do if I have a buddy).

The fact that somebody is willing to help me with this, would basically
mean that somebody cares enough to do it. If nobody joins .. my
conclusion will be that it's not important enough.

I also promise that all the renaming work is going to give you a 100%
insight in the design and implementation of tinymail. So if you are
really really interested in becoming my partner in crime for developing
tinymail ... that would definitely get you totally into its code.

> Maybe Mickey knows the answer? :)

Yes. I will be on holiday for the next two weeks :-). Next week will be
mostly Mickey Mouse in Paris (Tinnes decision, not mine). The week after
that will be dominated by festivals like Pukkelpop and Marktrock.

The idea is indeed to take a break.

The renaming would be for after those weeks.

BUT ... by then I hope to see a patch with some renaming initial
work ;-). And make a script with all the "svn mv x y" in.

But that's naive hope ;-). I launched the question a few days before my
holiday as a psychological tryout: make you guys want this, but noticing
that I can't do it myself in the next two weeks. Hehe.

If the (your, their) renaming breaks the python bindings, I'm willing to
take a look at that as that part might not be easy. However, with James
on this list .. we (or you guys during the next two weeks) can battle
all Python binding fights :). Right James?

I would, however, like to see the work before it gets committed. Most of
the people who are willing to do this have commit access already. You
guys *are* allowed to "svn cp trunk something" and work in "something"
while I'm away for this renaming.

Use Subversion. It's your tool.

Also during the two weeks that I'll be away: Don't be afraid to commit
crap. But try to fix it once you noticed that it is indeed crap :-).

"trunk" is for DEVELOPMENT. Not for I-WANT-A-STABLE-BLA-BLA whiners :)

I'll spell it: trunk is for d.e.v.e.l.o.p.m.e.n.t



-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]