Re: ORBit2 parallel install fixes



Mark McLoughlin <mark@skynet.ie> writes: 
> 	* We shouldn't be including IDL.h anywhere in ORBit2's sources
> 	apart from orbit-idl. I've fixed this in CVS.

OK, I'll nuke that part of the patch.

> 	* The namespacing of the headers to ${includedir}/orbit-2.0 is
> 	unneccesary, I think. ORBit-0.5.x headers reside in
> 	${includedir}/orb and ORBit2's in ${includedir}/orbit.

I believe we need it for ORBitservices and orbit-idl2.h anyway.

The reason I would advocate using orbit-2.0 for all of it is that the
strategy of s/orb/orbit/ clearly doesn't scale to orbit3. ;-) It's
nice and clean to just put everything in orbit-1.0 for orbit1, in
orbit-2.0 for orbit2, etc. But a matter of taste, just tell me what
you prefer, especially for ORBitservices and orbit-idl2.h

> 	* I'm curious about the change to ORBit-CosNaming-2.0.pc
> 	although I'd certainly defer to your wisdom on that ;)

Bad idea, I think my change was wrong. ;-) Taking that out.

> 	* I wonder can we kill the ORBIT2=1 define?

What does it do?

> 	* Can we try an solve your poa IDL_DIR problem seperately?

I had no idea how to address this; I think the Makefiles are a bit...
over-creative. ;-) I don't have time at the moment to reengineer the
ORBit2 build, so I will probably just move this patch to the spec file
if you don't want to clutter things in CVS. Or if there's another
simple fix you can think of I'm happy to use it.

Havoc




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]