Re: [PATCH 2/2] Send alive/byebye announcements three times.

[Sven Neumann <s neumann raumfeld com>]

On Wed, 2011-06-15 at 09:18 +0200, Sven Neumann wrote:
> On Tue, 2011-06-14 at 09:00 +0200, Jens Georg wrote:
> > On Di, 2011-06-14 at 08:57 +0200, Jens Georg wrote:
> > > UPnP recommends to send the whole batch of announcements more than
> > > once "due to the unreliable nature of UDP".
> > 
> > Since I have a really unreliable wireless and do have problems with not
> > seeing announcements due to packet loss, I think it's a good thing to
> > have.
> 
> We've been using a patch for quite a while that does something similar.
> I believe though that it is closer to what the spec suggests as it
> actually delays the duplicate advertisement sets a little.

Another patch we have been using to improve service discovery on
unreliable wireless networks is attached to this mail. It increases the
number of discovery messages. I am not sure whether this is a good thing
to apply for everyone. Perhaps this should be configurable somehow?


Regards,
Sven

-- 
Sven Neumann
Head of RAUMFELD Software Development

Lautsprecher Teufel GmbH | Bülowstr. 66 | 10783 Berlin | Germany
Tel: +49 (0)30-300 930 153 | s neumann raumfeld com

--- gssdp-0.6.4-orig/libgssdp/gssdp-resource-browser.c	2009-01-06 15:44:15.000000000 +0100
+++ gssdp-0.6.4/libgssdp/gssdp-resource-browser.c	2010-01-04 14:57:56.000000000 +0100
@@ -40,7 +40,7 @@
 #include "gssdp-protocol.h"
 #include "gssdp-marshal.h"
 
-#define MAX_DISCOVERY_MESSAGES 3
+#define MAX_DISCOVERY_MESSAGES 20
 #define DISCOVERY_FREQUENCY    500 /* 500 ms */
 
 G_DEFINE_TYPE (GSSDPResourceBrowser,