RE: [GnomeMeeting-list] Select custom alsa pcm device?

[Damien Sandras <dsandras seconix com>]

Le lundi 15 mai 2006 à 13:18 +0800, Stefan Brüns a écrit :
> > Le vendredi 12 mai 2006 à 22:32 +0800, Stefan Brüns a écrit :
> > > Any comments?
> > > 
> > 
> > A plugin that uses ini files can not go into the CVS, there are also
> > other problems, I will comment on them later.
> 
> As I have written in the previous mail, this is preliminary code. The ini
> file is only for adding custom devices _without_ changing the api.
> 
> As soon as the PSoundChannel API has a method to make adding of custom
> device names possible, the ini file can go away. You just have to make the
> "AddPcmDefinition(PString device, PSoundChannel::Direction)" a public method
> of PSoundChannel (and maybe give it a different name, as the name is
> somewhat alsa centric), and call this method from Ekiga. After that erase
> the 9 lines adding the definitions via the ini file from the plugin code.
> 
> In any case you need some way to supply the device names/pcm definitions to
> the plugin, because these can't be autodetected.
> 

Indeed. I would prefer that you change the API (for 2.2). That is not a
big change.

The rest of the code is ok.
-- 
 _      Damien Sandras
(o-     
//\     Ekiga Softphone: http://www.ekiga.org/
v_/_    FOSDEM 2006    : http://www.fosdem.org/
        SIP Phone      : sip:dsandras ekiga net
                         sip:600000 ekiga net