Re: [gnome-network] Request for gnome-nettool freeze break (1)



El dom, 12-09-2004 a las 06:37, Kjartan Maraas escribió:
> fre, 10,.09.2004 kl. 23.21 +0200, skrev Rodrigo Moya:
> > On Fri, 2004-09-10 at 16:42 -0400, Germán Poó Caamaño wrote:
> > > By mistake a made differents commits.  So, before to revert them
> > > I'd ask for approval to release-team.  Please, accept my apologies
> > > for that stupid mistake.
> > > 
> > > To make them clear, I divided the patches in differents emails.
> > > So here I go with the first one.
> > > 
> > > It just fixes the build in order to:
> > > - Use automake 1.7 and pass make distcheck.
> > > - Delete 'ifconfig' checker, that produce confuse and it's not
> > >   used from a while.
> > > 
> > > It's suppossed that build fixes doesn't require approval, but 
> > > because of the big mistake I prefer to ask it.
> > > 
> > approved from this end
> 
> If it really just fixes the build it shouldn't need release team
> approval. There's no changes in behaviour or new code paths being
> excercised as a result of removing the #ifdef part there?

No.  It just removed the commented code.

-- 
Germán Poó Caamaño
mailto:gpoo ubiobio cl
http://www.ubiobio.cl/~gpoo/




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]