Re: [gnome-db] Patch for port GnomeDbCombo to use GtkComboBoxEntry, and some modifications in GnomeDbForm



On Mon, 2004-10-11 at 13:43 -0500, Daniel Espinosa wrote:
> I add the patch, I have used the 1.1.6 original
> realise vs. my modified version, to make the diff file.
> 
looks ok, although this makes it depend on GTK 2.4. So, could you change
the patch (again, sorry :) and do what I did for the file chooser? That
is, use the:

#if GTK_CHECK_VERSION(2,4,0)
	write_gtk24_code
#else
	use_gtk < gtk24 code
#endif

Could you please provide a new patch with this?

Also, please add a ChangeLog entry, and make sure to get the diff file
using the CVS command rather than plain diff to compare 2 directories
(or you'll include all changes in the generated HTML files in the patch,
as you did with this one). That is:

cvs -z3 diff -u > diff_file

thanks again for your help
-- 
Rodrigo Moya <rodrigo gnome-db org>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]