Re: libbonoboui distcheck patch



Michael Meeks <michael ximian com> writes: 
> 	Yes - at least someone needs to put the effort into getting this right;
> I see neither glib nor gtk+ have done so [ where this ugly fragment was
> copied from ]. Autogenerating code into $(srcdir) is just really bad
> news, and it makes distcheck fail with newer autotools who write protect
> the source dir.
> 
> 	The whole thing sucks really; still - if it makes things build better
> for you - I suppose we can accept it temporarily with a heavy heart -
> but I'd like the situation properly fixed - and preferably without the
> need to cut and paste tens of lines of error prone Makefile ruleage from
> glib - which doesn't do it right anyway.
> 

If you know how to fix it, feel free. ;-) I have hated the GTK rules
forever.

In libwnck I just check the autogenerated files into CVS and have a
"make regenerate-built-sources" target. I just re-run "make
regenerate-built-sources" if I change the marshal list; it's no
problem to remember since code using the new marshaller won't run if
you don't regenerate. So no errors are likely due to that required
manual intervention, and the Makefile is simple, and always works, and
there are no headaches for me. The only really annoying bit left is
that glib-mkenums has all those weird options.

Of course inlinepixbufs.h still doesn't work properly in libwnck, I'm
more reluctant to do it that way since it should rebuild when changing
an image.

It's unfortunate that there's no good way to have "Makefile libraries"
to avoid cut-and-paste, but I really don't think there is a good way.

Havoc



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]