Dewarningization patch




Maciej Stachowiak writes:
 > @@ -1749,10 +1751,10 @@
 >  	BonoboUIHandlerMenuItem *item;
 >  
 >  	item = g_new0 (BonoboUIHandlerMenuItem, 1);
 > -	item->path        = path;
 > +	item->path        = strdup (path);
 >  	item->type        = type;
 > -	item->label       = label;
 > -	item->hint        = hint;
 > +	item->label       = strdup (label);
 > +	item->hint        = strdup (hint);
 >  	item->pos         = pos;
 >  	item->pixmap_type = pixmap_type;
 >  	item->pixmap_data = pixmap_data;

    This is a good catch.  Thanks for looking into that!  This patch
is definitely OK to apply.  Yes, please go ahead and commit changes
like this in the future, but when you touch a lot of stuff, I'd still
prefer it if you posted the patch and description to the mailing
list.  It's nice to be able to look back on the mailing list and see
why we did certain things.

Nat



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]