Re: [evolution-patches] Patch for bug 41839 (v2) , please review



Hmm, yeah i think this looks ok.  Although the used-twice
'is_button_press' variable probably isn't needed.

Is this code intended for the 1.4.x series, or for 1.5?  In 1.5, all of
this code is being completely redone (or at least, restructured
heavily).


On Fri, 2003-07-04 at 15:43, Yiming Cao wrote:
> Hi,
> 
> This patch is for bug 41839, which makes attachment (and signature)
> accessable with keyboard. Implemented as Ettore suggested:
>   Attachment and signature buttons are focused when accessed by
> keyboard, while not by mouse press. Hope this is the best choice.
> 
> Another minor bug fixed: the "inline" button is made insensitive when
> attachment can't be viewed inline, which seems more consistent with the
> popup menu's behavior.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]