Justin Wake wrote:
Well, after missing the tab grouping for a few releases, I finally got off my butt and rewrote it, first as a patch for 1.3.3/1.3.5 and then, this afternoon, as a proper extension.
Awesome! I'll most likely end up using this one :).One nitpick: I suggest, for future compatibility, that you test your extension against Epiphany with the latest patch from http://bugzilla.gnome.org/show_bug.cgi?id=148536 -- eventually Epiphany will support unloading/reloading of extensions, and we want to make sure your extension can support it. Right now, only the Gestures extension supports this (that I know of).
Off the top of my head, I think you should manually remove the data from the window on window-detach; window detach isn't necessarily on window destroy (it's also on extension unload). Besides that, I can't think of any other problems.
Christian will probably have some comments though! If it's okay with him, I'll gladly put the patch and extension into CVS if you don't have a login. Christian?
-- Adam Hooper adamh densi com
Attachment:
signature.asc
Description: OpenPGP digital signature