Re: [Epiphany] confused - debug works, non-debug doesn't

[Marco Pesenti Gritti <marco gnome org>]

On Sat, 2003-10-11 at 07:20, Christian Persch wrote:
> Hi,
> 
> On Sat, 2003-10-11 at 18:42, Marco Pesenti Gritti wrote:
> > Right it could be that. We should not assume there is an icon, assertion should
> > become if () g_warning there, or something.
> 
> Here's a trace from when the warning occurs:
> #0  g_object_ref (_object=0x0) at gobject.c:1289
>         __r = 0
> #1  0x4077f1b8 in gdk_window_set_icon (window=0x85ed7d0,
> icon_window=0x0, pixmap=0x0, mask=0x0) at gdkwindow-x11.c:3378
>         toplevel = (GdkToplevelX11 *) 0x8525980
> #2  0x4068cc50 in gtk_window_realize_icon (window=0x82dcc48) at
> gtkwindow.c:2525
>         widget = (GtkWidget *) 0x85ed7d0
>         info = (GtkWindowIconInfo *) 0x84717e0
>         icon_list = (GList *) 0x0
> #3  0x4068cfec in gtk_window_set_icon (window=0x82dcc48, icon=0x0) at
> gtkwindow.c:2690
>         list = (GList *) 0x0
> #4  0x0807ff73 in sync_tab_icon (tab=0x846d288, pspec=0x841e4a0,
> window=0x82dcc48) at ephy-window.c:704
>         address = <value optimized out>
>         cache = (EphyFaviconCache *) 0x0
>         pixbuf = (GdkPixbuf *) 0x0
> [etc.]
> 
> I think the problem is that normally [ie when the gnome-web-browser has
> been found and set as our default icon], we _can_ (and must) set a NULL
> icon which means it shows the default one instead of the favicon of the
> previous page. If, however, the gnome-web-browser icon has NOT been
> found and therefore there's no default icon, setting NULL will really
> try to set NULL icon as program icon, which won't work.
> 
> So I think the correct solution is to set a dummy, empty but non-NULL
> default icon when the gnome-web-browser icon can't be loaded.

Is there any reason gtk shouldnt handle this correctly ?
Like if you set NULL, but there is no previous icon just use default
icon. (or unset the icon, not sure how that works internally).
I dont like that much the dummy trick ;)

Marco