Re: extbody URL/mozilla dnd



Carlos,

I tested your patches (using the cvs), and I think there are two points which 
should be taken care of.

First, I think the form of the URL extbody attachment is not what '2017 
defines. E.g. your message source contains the following:

--=_Dxnq1zWXvFF0Q9
Content-Type: message/external-body;
	name="URL=\"http://www.balsa.net/main.html\"";; access-type=URL

Content-type: text/html

Note: this is _not_ the real body!

--=_Dxnq1zWXvFF0Q9

According to '2017, the right form would be

Content-Type: message/external-body;
	URL="http://www.balsa.net/main.html";; access-type=URL

Furthermore, the external body's content type is hard coded to "Content-type: 
text/html". This may be misleading, as the url might be e.g. 
http://www.stafford.uklinux.net/libesmtp/libesmtp-0.8.6.tar.bz2, which is 
obviously *not* text/html. However, I have no idea what we should put there 
(and just passing the url to the browser or the ftp client should work 
anyway).


The second point is that your patches break my implementation of the 
access-type=local-file extension. This was caused by just calling 
add_extbody_attachment() and adding URL to the beginning of the file name, 
which was also done during the callback from the popup. As a result, every
file reference became an URL...


I attach a patch (against today's cvs) which makes the local-file stuff work 
again (it's quite short, so you will see what it does). However, I have no 
idea how I can try the URL extbody; I use opera, and don't have Nutscrape 
here...

Cheers,

	Albrecht.


Am 16.10.2001 00:43:30 schrieb(en) Carlos Morgado:
> just commited support for RFC2017 URL external-body type and dnd or
> netscape/mozilla urls to the attachment box.
> i'm not very sure about the rfc2017 bit, so if anyone knows another mua
> that supports it give it a interop test please.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     Albrecht Dreß  -  Monschauer Straße 22  -  D-53121 Bonn (Germany)
       Phone (+49) 228 6199571  -  mailto:albrecht.dress@arcormail.de
_________________________________________________________________________

balsa-patches-20011017.gz



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]