Re: [PATCH] Replace GtkOptionMenu with GtkComboBox in file properties dialog

[Alexander Larsson <alexl redhat com>]

On Sun, 2005-11-27 at 16:43 +0100, Jaap Haitsma wrote:
> http://bugzilla.gnome.org/show_bug.cgi?id=322567

For the first patch:

You removed the separators from the dropdowns in the case of a
non-availible group/username. This can be implemented with 
gtk_combo_box_set_row_separator_func.

You need to ref (and unref) the files that you attach to the changes
signal for the group/username comboboxes.

Also, why the change in nautilus_get_user_names? You still have to split
and stuff in the code. I think spaces are not allowed in usernames, so
it should be safe. However, I don't think its necessary, and a bit
strange.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an obese neurotic boxer with nothing left to lose. She's a disco-crazy 
hypochondriac pearl diver in the witness protection program. They fight crime!