Re: eel input focus patch

[Mark McLoughlin <mark skynet ie>]

Hey,
	I could do the typical release-team yada yada, but this seems like a
safe, straightforward and obvious change to me.

	Approval 1 0f 2.

Good Luck,
Mark.

On Tue, 2003-09-02 at 15:57, Alexander Larsson wrote:
> Havoc just told me that using RevertToNone in XSetInputFocus is bad,
> since that means you can lose the input focus. hp knows the details of
> this. Is this ok to commit?
> 
> Index: eel/eel-gdk-extensions.c
> ===================================================================
> RCS file: /cvs/gnome/eel/eel/eel-gdk-extensions.c,v
> retrieving revision 1.20
> diff -u -p -r1.20 eel-gdk-extensions.c
> --- eel/eel-gdk-extensions.c    2 Oct 2002 05:17:57 -0000       1.20
> +++ eel/eel-gdk-extensions.c    2 Sep 2003 14:54:55 -0000
> @@ -642,7 +642,7 @@ eel_gdk_window_focus (GdkWindow *window,
>         gdk_error_trap_push ();
>         XSetInputFocus (GDK_DISPLAY (),
>                         GDK_WINDOW_XWINDOW (window),
> -                       RevertToNone,
> +                       RevertToPointerRoot,
>                         timestamp);
>         gdk_flush();
>         gdk_error_trap_pop ();
> 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    alexl redhat com    alla lysator liu se 
> He's a witless amnesiac romance novelist with nothing left to lose. She's a 
> radical hip-hop traffic cop with the power to bend men's minds. They fight 
> crime! 
> 
> _______________________________________________
> release-team mailing list
> release-team gnome org
> http://mail.gnome.org/mailman/listinfo/release-team