Re: [PATCH] Choose syntax



Hi Roland,

On Tue, 2005-07-12 at 08:52, Roland Illig wrote:
> - Blatantly ignoring any suggestions to follow common #include practice.

You mean because I forgot to #include "../src/global.h". That was
unintentional. However, you might want to explain (in headers.txt) why
this is necessary.

> ... as well as any suggestions to use gboolean when a variable is 
> clearly meant to be of a boolean type ...

As I said, ignoring any suggestion to use NULL, TRUE or FALSE (for now).
I'm quite comfortable with using 0, !0 and 0 instead :-p .

We might want to fix this globally, but I think it is ugly for me to
introduce a single (why g?)boolean where the code consistently uses
ints.

> ... as well as spelling errors. I don't care about them.

Yeah, that single quote is a "dutchism". I'll fix it.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]