Re: GtkBindingSignal changes

[Tim Janik <timj imendio com>]

On Wed, 4 Jan 2006, Xavier Bestel wrote:

> On Wed, 2006-01-04 at 13:28, Tim Janik wrote:
> > hi matthias,
> >
> > can you please outline the rationale for this change:
> >
> > 2005-12-27  Matthias Clasen  <mclasen redhat com>
> >
> >          * gtk/gtkbindings.h (GtkBindingSignal):
> >          * gtk/gtkbindings.c (binding_signal_new): Make the
> >          args a flexible array inside the struct, and allocate them
> >          together.
> >
> > i think this needs to be backed out because:
> >
> > 1) this is an incompatible ABI change (gtkbindings.h):
> >     -  GtkBindingArg          *args;
> >     +  GtkBindingArg          args[1]; /* flexible array */
>
> Should probably be args[0] there (and change the g_malloc0()
> accordingly).

args[0] is not portable C beyond C99 unfortunately.

> 	Xav

---
ciaoTJ