Re: [GnomeMeeting-devel-list] Questions on gnomemeeting-opal's src/endpoint.cpp

[Damien Sandras <dsandras seconix com>]

Hi,

Le dimanche 29 mai 2005 à 18:25 +0200, Julien PUYDT a écrit :
> Hi,
> 
> I tried reading src/endpoint.cpp to see how it now looks, and have 
> several questions/remarks:
> 1) the function GetRegisteredAccounts uses an ill-named int "sip" to 
> denote an integer which in fact adds h323 and sip accounts' numbers ; I 
> propose the following trivial patch to rename it to "number":
> @@ -2554,13 +2554,13 @@
>   int
>   GMEndPoint::GetRegisteredAccounts ()
>   {
> -  int sip = 0;
> +  int number = 0;
> 
> -  sip = sipEP->GetRegisteredAccounts ();
> +  number = sipEP->GetRegisteredAccounts ();
>     if (h323EP->IsRegisteredWithGatekeeper ())
> -    sip++;
> +    number++;
> 
> -  return sip;
> +  return number;
>   }
> 

I'm in Germany, perhaps Migras can commit it? Or you?


> 
> 2) SetTransferCallToken and GetTransferCallToken don't use 
> PWaitAndSignal but explicitly do the Wait, something, then the Signal ; 
> why is it so?

It comes from the old gnomemeeting, currently being transferred doesn't
work, so it is not used anymore. So that code needs to be reviewed once
I get "being transferred" working.


> 3) I don't understand what all those "pc:" thingies are about (as seen 
> in AddRouteEntry or OpalManager::SetupCall function calls.
> 
> I wonder if my next step will be reading some more opal or some more 
> gnomemeeting-opal :-/
> 

To summarize (Ive not had time to write my opal howto here as tehre is
no power and my battery is weak):
- An OpalManager manages several endpoints
- Each endpoint is able to do calls following a protocol
- In the future, if the protocols are different, there will be automatic
translation (for proxies and gateways) and automatic mixing, for now, it
is not the case

When you are doing a call, you create an OpalCall object. Each calls has
several OpalConnections involved, following the protocol. If you are
doing a SIP Call, you create an OpalCall object with 2 connections :
- 1 SIPConnection
- 1 PCSSConnection
The SIPConnection is managed by the SIPEndPoint
The PCSSConnection is managed by the PCSSEndPoint, which is not a real
protocol, with transcoding, but the PC Sound System endpoint.

In the future, for gateways, you will be able to remove the
PCSSConnection and replace it by an H.323 Connection for example.

Anyway, in GnomeMeeting's case, each call only contains 2 connections,
one to the LOCAL PCSSEndPoint (PCSSConnection) and one to the REMOTE
SIPEndPoint (SIPConnection).

When you are being transferred, you keep the PCSSConnection in the call,
and remove the SIPConnection to replace it by another one to another
endpoint.

Those are the basics.

An OpalMediaStream is the connection between a source and a sink.
Obviously you will for example have : PCM-16 -> G.711 codec (encoding)
and G.711 -> PCM-16 (decoding). Because an OpalMediaStream related to a
PCSSConnection is of type PCM-16, for example.




> Snark
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
-- 
 _      Damien Sandras
(o-     GnomeMeeting: http://www.gnomemeeting.org/
//\     FOSDEM 2005 : http://www.fosdem.org
v_/_    H.323 phone : callto:ils.seconix.com/dsandras seconix com