Re: adding new info to GnomeVFSFileInfo



On Tue, Oct 08, 2002 at 09:34:25AM +0100, Michael Meeks wrote:
> > it couldn't test if a directory is readable before adding it to its
> > library). So I think it looks like something worth adding.
> 
> 	Fine.
Agreed.

> > > 	If you add an options mask / guard around those ops, it looks fine to
> > > commit to me.
> > 
> > I'm a little concerned about the way I extended the enum starting after
> > bit 16. Is it possible that some C compiler pack the old enum in a word,
> > and will have to use a 32bit int instead, thus breaking abi compat ?
> 
> 	AFAIR an enum is of type 'int', and platforms with a 16bit int are not
> supported by Gnome, so - this shouldn't be a concern I think. The guard
> is crucial though.

The compiler is required to make the enum storage large enough to
hold the largest enum value or provide a warning that it can not.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]