Re: String freeze breakage: gnome-applets/po-locations/*

[Simos Xenitellis <simos74 gmx net>]

On Sun, 2004-08-22 at 01:00, Christian Rose wrote:
> sön 2004-08-22 klockan 01.28 skrev Simos Xenitellis:
> > > Can you tell us:
> > > 
> > > * What changed? Which exact messages were affected?
> > 
> > What changed: 
> > Entries related to the file gnome-applets/gweather/Locations.xml.in
> > with regards to countries: Greece, Cyprus.
> > 
> > What exact messages were affected (diff between original file to final
> > file):
> 
> Ok, thanks.
> 
> 
> > > * Where's the Bugzilla bug report where this patch was discussed?
> > 
> > I did not submit the above patch as a bug report, if you are referring
> > to that.
> > 
> > In a previous e-mail I was referring to the explanation provided in this
> > bug report:
> > http://bugzilla.gnome.org/show_bug.cgi?id=89746#c53
> 
> If you want to break string freeze, please always put your patch in a
> bug report so that it can be appropriately examined and reviewed.
> 
> 
> > > * Why couldn't this change have been applied before the freeze, and why
> > > can't it wait until after the freeze?
> > 
> > I did not know that gnome-applets/po-locations/ were counted in the
> > string freeze.
> > 
> > I was having in mind what I said in
> > http://bugzilla.gnome.org/show_bug.cgi?id=89746#c53
> > that po-Locations should not be part of the stats (therefore string
> > freeze), as it is impractical 
> > to translate all messages. 
> 
> String freeze goes by modules, not domains. gnome-applets HEAD is string
> frozen, period.
> 
> (and po-locations is part of our stats, but that's irrelevant to this
> discussion).
> 
> 
> [...]
> > > After we have that information, *then* we can discuss whether this
> > > change is important enough to breake the freeze and whether it should be
> > > reverted or not.
> > 
> > I do not press you to accept the changes. Feel free to revert my commits
> > as I may re-apply them after this release.
> 
> I don't approve of the changes.
> 
> 1) There was ample of time before to fix this issue, and the schedule
> was public.
> 2) I don't see why there is a need to absolutely break the freeze for
> these changes, and why it absolutely can't wait. In no way does this
> look like critical bugs that can't wait until the freeze is over.
> 
> (and in addition, string freeze is there for translators. If translators
> themselves are the worst offenders and not respecting the freeze and
> respecting other translators, then we probably will have a hard time to
> convince maintainers to respect it aswell)
> 
> Thus, I'd like you to revert these changes from HEAD as soon as
> possible.

Changes just reverted from HEAD to previous (string freeze) state.

I used the "cvs update -j ``current'' -j ``previous'' Locations.xml.in"
syntax to rollback the changes, then "cvs commit". Also reverted
ChangeLog. Please advise if it's wrong. Verified manually that changes
were reverted properly.

> 
> Put your patch in a bug report and then we might perhaps revisit this
> after the 2.8.0 release.

Bug report created.
http://bugzilla.gnome.org/show_bug.cgi?id=150744

Regards,
Simos Xenitellis